Fix broken windows build #3684
Merged
Fix broken windows build #3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StasJ
reviewed
Nov 19, 2024
|
Hey, no problem.
Yes, I commented on this in the main PR. I feel like Windows keeps tending to bite us after a PR is merged. Our CI usage has gone down so I enabled it here to save us this kind of headache in the future, but let's deliberate at today's meeting or via email/here. |
StasJ
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #3677, which reports a broken windows build. This also enables our build_win10_installer test on PR's since windows frequently breaks our build and it would be nice to find out about this at PR submission time.